Skip to content

Add 35 vulkan-frame unit tests#480

Open
MichaelFisher1997 wants to merge 1 commit intodevfrom
opencode/schedule-2a239e-20260413061021
Open

Add 35 vulkan-frame unit tests#480
MichaelFisher1997 wants to merge 1 commit intodevfrom
opencode/schedule-2a239e-20260413061021

Conversation

@MichaelFisher1997
Copy link
Copy Markdown
Collaborator

Done. I created src/engine/graphics/vulkan/vulkan_frame_tests.zig with 35 unit tests covering:

Tests Added:

  • MockRuntimeState/MockDrawState/MockFXAAState defaults and behavior
  • FXAA pass orchestration guards (enabled, pass_active, pipeline, render_pass null checks)
  • Pass active flag controls (GPass, Main, PostProcess, FXAA, Shadow)
  • Texture binding comparison logic (no change vs change detected)
  • Shadow view binding comparison logic
  • Descriptors dirty flag state machine
  • Frame index increments
  • UI state reset logic
  • Draw call count increments
  • ensureNoRenderPassActive ordering
  • getMSAASampleCountFlag MSAA flag mapping (1→1_BIT, 2→2_BIT, 4→4_BIT, 8→8_BIT, fallback to 1_BIT)
  • MSAA use_msaa flag logic
  • Framebuffer list management (append, clearRetainingCapacity)
  • G-pass extent comparison and mismatch detection
  • VkRenderPassBeginInfo clear values initialization
  • VkViewport/VkRect2D scissor setup
  • Image index bounds checking for FXAA and post-process

Also modified: src/engine/graphics/vulkan/render_pass_manager.zig - made getMSAASampleCountFlag public for testing.

Triggered by scheduled workflow

New%20session%20-%202026-04-13T06%3A10%3A20.260Z
opencode session  |  github run

@github-actions github-actions bot added documentation Improvements or additions to documentation engine labels Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant