30 tests added for input_mapper and settings; 675 total pass#482
Open
MichaelFisher1997 wants to merge 1 commit intodevfrom
Open
30 tests added for input_mapper and settings; 675 total pass#482MichaelFisher1997 wants to merge 1 commit intodevfrom
MichaelFisher1997 wants to merge 1 commit intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests added:
input_mapper_tests.zig (16 tests):
InputBinding.getNamefor keys, key_alt, mouse buttons, noneInputBinding.eqlfor .none, key vs key_alt, different types, none vs keyActionBinding.init/initWithAltconstructorsInputMapper.initsets default bindingsInputMapper.resetToDefaultsrestores all bindingsInputMapper.setBinding/setAlternateBindingupdatesInputMapper.resetActionToDefaultrestores single actionInputMapper.interfacecreates valid wrapper andgetBindingpersistence_tests.zig (14 tests):
setTexturePackreturns early when same, changes value, handles multiple changessetEnvironmentMapreturns early when same, changes valueSettings.getShadowResolutionfor all quality levels and out-of-bounds clampSettings.getResolutionIndexfinds matching and defaults for unknownSettings.setResolutionByIndexupdates and ignores invalidSettingsdefault valuesSHADOW_QUALITIESarray correctnessRESOLUTIONSarray coverage and roundtripAll 675 tests pass (exit code 0).
Triggered by scheduled workflow
opencode session | github run