Prevents BOARD_LED_PIN from being overwritten in BOARD_LED add-on#1624
Open
MerlinDesigns wants to merge 4 commits into
Open
Prevents BOARD_LED_PIN from being overwritten in BOARD_LED add-on#1624MerlinDesigns wants to merge 4 commits into
MerlinDesigns wants to merge 4 commits into
Conversation
Contributor
|
Looks like this breaks for PICOW because there is no define for the PICOW LEDs :( |
Contributor
|
Looks like its still failing on picoW :( |
Author
|
@arntsonl I changed it to have the old default value as a fall back. Checked that the builds all work on the Alpenmeister repo |
arntsonl
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
BOARD_LED_PINgets overwritten by the board LED add-on. This fix prevents this from happening.