Skip to content

Refactor AttributeGraphVendor to RawRepresentable struct #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 2 commits into from
Mar 10, 2026
Merged

Refactor AttributeGraphVendor to RawRepresentable struct #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cef543
Refactor AttributeGraphVendor from enum to RawRepresentable struct
Kyle-Ye Mar 10, 2026
eedc91a
Update shims file name
Kyle-Ye Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions .../OpenAttributeGraphShims/GraphShims.swift → ...es/OpenAttributeGraphShims/OAGShims.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,27 @@
//
// GraphShims.swift
// AGShims.swift
// OpenAttributeGraphShims

public enum AttributeGraphVendor: String {
case oag = "org.OpenSwiftUIProject.OpenAttributeGraph"
case ag = "com.apple.AttributeGraph"
case compute = "dev.incrematic.compute"
/// A type that identifies the underlying attribute graph implementation vendor.
///
/// Use `attributeGraphVendor` to check which vendor is active at runtime.
public struct AttributeGraphVendor: RawRepresentable, Hashable, CaseIterable {
public let rawValue: String

public init(rawValue: String) {
Copy link

@augmentcode augmentcode bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AttributeGraphVendor(rawValue:) used to be failable when it was a RawRepresentable enum; making it non-failable can break downstream code that does optional binding (if let) or force-unwrapping on this initializer. If source-compatibility is a goal, consider also providing a failable init?(rawValue:) entry point.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

self.rawValue = rawValue
}

/// OpenAttributeGraph — the open-source implementation by OpenSwiftUIProject.
public static let oag = AttributeGraphVendor(rawValue: "org.OpenSwiftUIProject.OpenAttributeGraph")

/// Apple's private AttributeGraph framework.
public static let ag = AttributeGraphVendor(rawValue: "com.apple.AttributeGraph")

/// An incremental computation library for Swift by @jcmosc
public static let compute = AttributeGraphVendor(rawValue: "dev.incrematic.compute")

public static var allCases: [AttributeGraphVendor] { [.oag, .ag, .compute] }
}

#if OPENATTRIBUTEGRAPH_COMPUTE
Expand Down
2 changes: 1 addition & 1 deletion ...eGraphCompatibilityTests/GraphShims.swift → ...uteGraphCompatibilityTests/OAGShims.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// GraphShims.swift
// OAGShims.swift
// OpenAttributeGraphCompatibilityTests

#if OPENATTRIBUTEGRAPH
Expand Down