Skip to content

Add ORBSymbolAnimator and ORBAnimation support#23

Merged
Kyle-Ye merged 2 commits intomainfrom
feature/ORBSymbolAnimator
Mar 7, 2026
Merged

Add ORBSymbolAnimator and ORBAnimation support#23
Kyle-Ye merged 2 commits intomainfrom
feature/ORBSymbolAnimator

Conversation

@Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Mar 7, 2026

Add ORBAnimation, ORBSymbolAnimator, and ORBSymbolAnimatorObserver with full API surface.

Changes

ObjC Headers (OpenRenderBoxCxx/include/OpenRenderBoxObjC/Animation/)

  • ORBAnimation.h@interface ORBAnimation : NSObject <NSCopying> with animation composition API
  • ORBSymbolAnimatorObserver.h@protocol ORBSymbolAnimatorObserver <NSObject>
  • ORBSymbolAnimator.h@interface ORBSymbolAnimator : NSObject with full property/method surface

ObjC Implementations (OpenRenderBoxCxx/Animation/)

  • ORBAnimation.m / ORBSymbolAnimator.m — stub @implementation guarded with #if ORB_OBJC_FOUNDATION

Swift Shims (OpenRenderBox/Animation/)

  • ORBAnimation.swiftNSObject subclass with full API matching ObjC interface (#if !canImport(ObjectiveC))
  • ORBSymbolAnimator.swiftNSObject subclass + ORBSymbolAnimatorObserver protocol (#if !canImport(ObjectiveC))

Exports

  • OpenRenderBoxShims/Export.swift — added ORBAnimation, ORBSymbolAnimator, ORBSymbolAnimatorObserver type aliases

Tests

  • AnimationTests.swift — 8 test cases covering all animation composition methods
  • SymbolAnimatorTests.swift — 5 test cases covering properties, animation management, and geometry

Dependencies

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (ba06b06) to head (6c7fee1).

Files with missing lines Patch % Lines
...es/OpenRenderBox/Animation/ORBSymbolAnimator.swift 0.00% 53 Missing ⚠️
Sources/OpenRenderBox/Animation/ORBAnimation.swift 0.00% 21 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #23   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          4       6    +2     
  Lines        123     197   +74     
=====================================
- Misses       123     197   +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye changed the title Add ORBSymbolAnimator and ORBAnimation support (#23) Add ORBSymbolAnimator and ORBAnimation support Mar 7, 2026
@Kyle-Ye Kyle-Ye merged commit 5ae2d67 into main Mar 7, 2026
4 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/ORBSymbolAnimator branch March 7, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants