Skip to content

Fix ObservableExampleApp build issue for SUI#803

Merged
Kyle-Ye merged 1 commit intomainfrom
k-branch-2
Mar 1, 2026
Merged

Fix ObservableExampleApp build issue for SUI#803
Kyle-Ye merged 1 commit intomainfrom
k-branch-2

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Mar 1, 2026

No description provided.

@github-actions github-actions bot added bug Something isn't working build issue labels Mar 1, 2026
@augmentcode
Copy link

augmentcode bot commented Mar 1, 2026

🤖 Augment PR Summary

Summary: Fixes the ObservableExampleApp target failing to build when using SwiftUI by adjusting how imports are conditionally compiled.

Changes:

  • Moves import OpenObservation inside the #if OPENSWIFTUI/#else branches so it’s consistently available alongside either OpenSwiftUI or SwiftUI.
  • Removes the now-redundant unconditional import OpenObservation at the bottom of the import block.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye merged commit fd30b84 into main Mar 1, 2026
6 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-2 branch March 1, 2026 19:09
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.71%. Comparing base (441a868) to head (cbbbef1).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (441a868) and HEAD (cbbbef1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (441a868) HEAD (cbbbef1)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #803       +/-   ##
===========================================
- Coverage   27.63%   13.71%   -13.93%     
===========================================
  Files         657      622       -35     
  Lines       41224    37153     -4071     
===========================================
- Hits        11392     5094     -6298     
- Misses      29832    32059     +2227     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant