Add Foundation ProtobufMessage conformances (URL, UUID, Data, Locale)#804
Add Foundation ProtobufMessage conformances (URL, UUID, Data, Locale)#804
Conversation
🤖 Augment PR SummarySummary: This PR adds protobuf serialization support for several Foundation types to better match SwiftUICore’s on-device encoding/decoding. Changes:
Technical Notes: URL encoding includes an optional nested base URL message; UUID uses a 16-byte data payload; tests assert exact hex encodings to ensure wire-format parity with SwiftUICore. 🤖 Was this summary useful? React with 👍 or 👎 |
| let compatibilityTestCondition = envBoolValue("COMPATIBILITY_TEST") | ||
|
|
||
| let useLocalDeps = envBoolValue("USE_LOCAL_DEPS") | ||
| let useLocalDeps = envBoolValue("USE_LOCAL_DEPS", default: true) |
There was a problem hiding this comment.
Defaulting USE_LOCAL_DEPS to true means a default swift build will try to resolve sibling path dependencies (e.g. ../OpenCoreGraphics, ../OpenObservation) and can fail for users/CI that don’t have those checkouts. Is it intentional that the “local deps” mode is now the default behavior?
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Summary
ProtobufMessageconformances forURL,UUID,Data, andLocalein a single fileFoundation+ProtobufMessage.swiftTest plan
swift test --filter FoundationProtobufMessagepasses all 4 test suites (URL, UUID, Data, Locale)