Skip to content

Add Shared assets for Example project#813

Merged
Kyle-Ye merged 3 commits intomainfrom
k-branch-1
Mar 8, 2026
Merged

Add Shared assets for Example project#813
Kyle-Ye merged 3 commits intomainfrom
k-branch-1

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Mar 8, 2026

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Mar 8, 2026
@Kyle-Ye Kyle-Ye merged commit 1e46475 into main Mar 8, 2026
7 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch March 8, 2026 07:58
@augmentcode
Copy link

augmentcode bot commented Mar 8, 2026

🤖 Augment PR Summary

Summary: This PR consolidates shared Example assets and source files into a new Example/Shared folder to be reused across the sample apps and UI tests.

Changes:

  • Renames SharedExampleShared and updates file headers accordingly.
  • Moves app icons, colors, and images into a shared Assets.xcassets under Example/Shared/Assets and removes per-target asset catalog files.
  • Updates snapshot/UI tests to reuse shared example views (e.g. ForEachOffsetExample, ForEachKeyPathExample).
  • Wires the Shared folder into the TestingHost target via file-system synchronized groups.
  • Adds the Equatable SwiftPM product to TestingHost and OpenSwiftUIUITests to support shared demo views.

Technical Notes: Xcode project settings are adjusted to reflect the new shared structure and dependencies.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

);
fileSystemSynchronizedGroups = (
275751E42DEE1441003E467C /* TestingHost */,
27FFF0422E08850C0060A4DA /* Shared */,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding the Shared synchronized group to TestingHost, this also changes which Shared sources get built into the test host (notably interpose.c, which interposes swift_dynamicCast/kdebug_is_enabled). Worth double-checking this broader linkage is intended for TestingHost in all configurations.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.39%. Comparing base (de7cbe7) to head (fe4d8d4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #813       +/-   ##
===========================================
+ Coverage   13.98%   27.39%   +13.40%     
===========================================
  Files         624      659       +35     
  Lines       37822    42366     +4544     
===========================================
+ Hits         5290    11605     +6315     
+ Misses      32532    30761     -1771     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant