Fix named image mask rendering and load system vector image issue#815
Fix named image mask rendering and load system vector image issue#815
Conversation
🤖 Augment PR SummarySummary: This PR fixes image mask rendering and improves system vector image loading, while adding coverage for named image rendering modes. Changes:
Technical Notes: Template rendering relies on 🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| func resolve(in context: ImageResolutionContext) -> Image.Resolved { | ||
| var context = context | ||
| if !context.environment.imageIsTemplate(renderingMode: renderingMode), |
There was a problem hiding this comment.
The condition that sets context.symbolRenderingMode = .multicolor triggers whenever the effective template mode is non-template, which also includes the renderingMode: nil (reset-to-default) case; that may unintentionally change default SF Symbol behavior compared to not calling renderingMode at all. (Also applies to the same logic in resolveNamedImage below.)
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
=======================================
Coverage 27.47% 27.48%
=======================================
Files 660 661 +1
Lines 42405 42429 +24
=======================================
+ Hits 11652 11661 +9
- Misses 30753 30768 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.