Skip to content

Update to use ORB instead of RB#820

Merged
Kyle-Ye merged 1 commit intomainfrom
k-branch-1
Mar 10, 2026
Merged

Update to use ORB instead of RB#820
Kyle-Ye merged 1 commit intomainfrom
k-branch-1

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Mar 10, 2026

No description provided.

@Kyle-Ye Kyle-Ye requested a review from Mx-Iris as a code owner March 10, 2026 16:15
@github-actions github-actions bot added enhancement New feature or request RenderEffect labels Mar 10, 2026
@augmentcode
Copy link

augmentcode bot commented Mar 10, 2026

🤖 Augment PR Summary

Summary: This PR continues the RenderBox (RB) → OpenRenderBox (ORB) migration by renaming key types and API surfaces to ORB terminology and updating dependencies.

Changes:

  • Bumps pinned revisions for OpenAttributeGraph and OpenRenderBox in Package.resolved
  • Renames accelerated drawing types from RBDrawingView/Layer to ORBDrawingView/Layer and updates platform display-list view creation
  • Renames RenderBoxView/RenderBoxLayer to OpenRenderBoxView/OpenRenderBoxLayer
  • Updates PlatformDrawableOptions and related call sites from rbLayer to orbLayer
  • Renames RenderBox-facing shims and payloads: RBDisplayListContentsORBDisplayListContents, plus interpolator/content case names
  • Updates rasterization configuration from rbColorModeorbColorMode
  • Updates path storage naming from rbPathorbPath across Swift and C/ObjC overlays

Technical Notes: The changes are largely mechanical renames intended to align the codebase with ORB naming while keeping accelerated rendering paths routed through ORBDevice/ORBLayer when available.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

var list: DisplayList
var origin: CGPoint
var rbList: ORBDisplayListContents
var orbList: ORBDisplayListContents
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ORBDisplayListContents is a protocol (see RenderBoxShims.swift), so storing it as var orbList: ORBDisplayListContents may run into Swift 6 existential rules (and is inconsistent with drawing(any ORBDisplayListContents, ...)). Consider making the existential explicit here to avoid build breaks/warnings under Swift 6 language mode.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

/// When non-nil overrides colorMode with a member of the
/// `RBColorMode` enum, specified as its raw integer value.
public var rbColorMode: Int32?
public var orbColorMode: Int32?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc comment above orbColorMode still refers to RBColorMode, which seems outdated after the RB→ORB rename. Consider updating the documentation to the current ORB naming so callers know which enum/raw values are expected.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@Kyle-Ye Kyle-Ye merged commit 9e06f2d into main Mar 10, 2026
10 of 11 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch March 10, 2026 16:27
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.49%. Comparing base (afdfcda) to head (962d693).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Shape/Path.swift 0.00% 16 Missing ⚠️
...ces/OpenSwiftUICore/View/Image/GraphicsImage.swift 0.00% 7 Missing ⚠️
...OpenSwiftUI/Render/DisplayList/RenderBoxView.swift 0.00% 6 Missing ⚠️
.../OpenSwiftUICore/Render/RasterizationOptions.swift 0.00% 5 Missing ⚠️
...SwiftUI/Render/DisplayList/AppKitDisplayList.swift 0.00% 3 Missing ⚠️
...DisplayList/CAHostingLayerPlatformDefinition.swift 0.00% 3 Missing ⚠️
...UI/Render/DisplayList/DisplayListViewDrawing.swift 0.00% 2 Missing ⚠️
...rces/OpenSwiftUICore/Render/PlatformDrawable.swift 0.00% 2 Missing ⚠️
Sources/OpenSwiftUICore/Shape/PathData.swift 0.00% 2 Missing ⚠️
...enSwiftUICore/View/Image/SymbolRenderingMode.swift 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #820   +/-   ##
=======================================
  Coverage   27.48%   27.49%           
=======================================
  Files         661      661           
  Lines       42444    42444           
=======================================
+ Hits        11667    11671    +4     
+ Misses      30777    30773    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request RenderEffect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant