[fix](style) make the component more adjustable at different appSize#43
Open
areski wants to merge 8 commits intoOpenTelecom:devfrom
Open
[fix](style) make the component more adjustable at different appSize#43areski wants to merge 8 commits intoOpenTelecom:devfrom
areski wants to merge 8 commits intoOpenTelecom:devfrom
Conversation
…nternational number
Contributor
Author
|
@noahmehl Any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is making React-SIP-Phone more adjustable with 3 different sizes: small, medium & large.
I tried to keep most of the existing styles byt at the same time offering 2 smaller sizes, it can now nicely shrink down on a div with 150px of width, so that offers the ability to have a much thinner webphone.
There is smaller changes on colours choice, hover effect.
You will notice a lot of code for the styling of the react-select, that was unfortunately necessary.
On a second phase it might be nice to get rid of the images icons and import some SVG ones from a library.