fix(changelog): support theme-aware release media - #56
Conversation
|
Warning Review limit reachedNext included review available in 52 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changelog image pipeline now supports GitHub release assets, caches ChangesTheme-aware changelog images
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change is localized to theme-aware changelog media handling and has no actionable merge-blocking risk remaining after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant ChangelogMarkdown
participant ImageCache
participant Sharp
participant Sanitizer
participant ThemeSignal
participant Browser
ChangelogMarkdown->>ImageCache: process img src and source srcSet
ImageCache->>Sharp: decode and validate image bytes
Sharp-->>ImageCache: image format and dimensions
ImageCache->>Sanitizer: emit cached themed picture markup
Sanitizer-->>ChangelogMarkdown: sanitized HTML
ThemeSignal->>Browser: apply resolved theme
Browser->>Browser: enable matching source and disable other source
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a narrowly scoped changelog bug fix that restores and locally caches release-picture sources, preserves their theme metadata, and synchronizes them with the existing site theme selector. Runtime impact is limited to changelog media selection, with coverage for the rendering and caching path. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Release notes can now contain dark and light
<picture>media hosted inOpenTubeX/media, but the website previously stripped each source URL, rejected GitHub release-asset downloads, and followed only the operating-system theme instead of the website selector.This preserves and caches
<source srcset>images, accepts GitHub release assets after validating their actual raster format, and connects the picture sources to the website’s resolved Light, Dark, or Auto theme. The original media queries remain as the no-JavaScript fallback.The PR also bundles every currently open Dependabot update:
astro-icon1.2.0 from chore(deps): bump astro-icon from 1.1.5 to 1.2.0 #53@iconify-json/lucide1.2.124 from chore(deps): bump @iconify-json/lucide from 1.2.123 to 1.2.124 #54@astrojs/markdown-remark7.2.3 from chore(deps): bump @astrojs/markdown-remark from 7.2.3 to 7.2.4 #55Testing
bun install --frozen-lockfilebun test