fix: keep legacy sync migration complete after playback-speed cleanup

[D3SOX]

Deleting a migrated playbackSpeeds collection can restart legacy migration. Allow clients that have successfully synced playback speeds into settings to acknowledge that through GET /v1/encrypted_sync?playback_speeds_in_settings=true; those requests no longer require the deprecated collection for completion.

Default requests preserve the previous completion rule. This protects older clients and interrupted migrations, including accounts with unrelated encrypted settings but speeds still only in the original document. Existing collection GET/PUT and legacy document reads remain available. Older clients may still recreate a deleted collection through their existing migration behavior.

The HTTP regression covers interrupted uploads, unrelated settings, old-client default requests, explicit acknowledgment after migration, deletion, and continued legacy endpoint access. All 57 server tests and Rust formatting checks pass. No database migration is added.

Companion client PR: OpenTubeX/OpenTubeX#1151

Implemented with GPT-6 through Codex.

[coderabbitai]

Warning

Review limit reached

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 4ef0b1fd-d82d-4205-bb62-0e14c41b4acc

📥 Commits

Reviewing files that changed from the base of the PR and between 37a009f and 77e7ed1.

📒 Files selected for processing (2)

• README.md
• src/handlers/encrypted_sync.rs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: c33cfd74-36c6-4e0f-81d3-c7632f187d15

📥 Commits

Reviewing files that changed from the base of the PR and between b0c503e and 37a009f.

📒 Files selected for processing (2)

• README.md
• src/handlers/encrypted_sync.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The deprecated playbackSpeeds collection is no longer required to complete legacy encrypted migration. Integration tests verify migration status, collection visibility, revision behavior, and legacy document access.

Changes

Legacy encrypted migration

Layer / File(s)	Summary
Migration tracking and validation src/handlers/encrypted_sync.rs, README.md	Legacy migration tracking excludes playbackSpeeds. Collection limits remain defined for the deprecated collection. SQLite integration tests cover migrated and deleted playbackSpeeds rows, manifest status, collection responses, and legacy document access. The README documents the client migration behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 37a00

Clients may delete the deprecated playbackSpeeds collection without being prompted to repeat encrypted migration; the collection remains supported for legacy reads and its limits remain unchanged. The covered behavior is ready to merge.

Suggested reviewers: bnyro

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the main change: legacy sync migration remains complete after deprecated playback-speed data is cleaned up.
Description check	✅ Passed	The description directly explains the migration behavior, compatibility rules, regression coverage, and preserved endpoints described in the changeset.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch finish-playback-speeds-deprecation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}