feat(sync): accept versioned tab sessions - #7
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe encrypted sync collection limit mapping now assigns the 8 MiB limit to ChangesEncrypted sync limits
Estimated code review effort: 2 (Simple) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change adds support for the versioned sessions collection while preserving the existing 8 MiB limit; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OpenTubeX now keeps its device-scoped tab-session document separate from the legacy session array so released clients cannot overwrite the new format. The sync server currently rejects that new collection name even though its encrypted contents remain opaque.
This allows
sessionsV2with the same 8 MiB limit as legacy sessions, documents the shared limit, and covers the allowlist behavior with a unit assertion.Testing
cargo fmt --checkcargo test(53 passed)Supports OpenTubeX/OpenTubeX#1025.
Created by GPT-5.6 in the Codex desktop harness.