Skip to content

feat(sync): accept versioned tab sessions - #7

Merged
D3SOX merged 1 commit into
mainfrom
support-versioned-sessions
Sep 2, 2026
Merged

feat(sync): accept versioned tab sessions#7
D3SOX merged 1 commit into
mainfrom
support-versioned-sessions

Conversation

@D3SOX

@D3SOX D3SOX commented Sep 2, 2026

Copy link
Copy Markdown
Member

OpenTubeX now keeps its device-scoped tab-session document separate from the legacy session array so released clients cannot overwrite the new format. The sync server currently rejects that new collection name even though its encrypted contents remain opaque.

This allows sessionsV2 with the same 8 MiB limit as legacy sessions, documents the shared limit, and covers the allowlist behavior with a unit assertion.

Testing

  • cargo fmt --check
  • cargo test (53 passed)
  • Physical compatibility test against an isolated copy of the public SQLite database

Supports OpenTubeX/OpenTubeX#1025.


Created by GPT-5.6 in the Codex desktop harness.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 5a46248e-7d9e-49ff-a81d-3ebed60c2729

📥 Commits

Reviewing files that changed from the base of the PR and between 00d8478 and dbb767d.

📒 Files selected for processing (2)
  • README.md
  • src/handlers/encrypted_sync.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The encrypted sync collection limit mapping now assigns the 8 MiB limit to sessionsV2. The handler test verifies this mapping, and the README documents the updated collection scope.

Changes

Encrypted sync limits

Layer / File(s) Summary
Session collection limit mapping
src/handlers/encrypted_sync.rs, README.md
collection_limit recognizes sessionsV2 as an 8 MiB collection. The test verifies the mapping, and the README documents the updated scope.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to dbb76

The change adds support for the versioned sessions collection while preserving the existing 8 MiB limit; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: bnyro

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: support for versioned tab sessions in sync.
Description check ✅ Passed The description directly explains support for the sessionsV2 collection, its 8 MiB limit, documentation, test coverage, and compatibility testing.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch support-versioned-sessions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@D3SOX
D3SOX merged commit c0661bd into main Sep 2, 2026
9 checks passed
@D3SOX
D3SOX deleted the support-versioned-sessions branch September 2, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant