spec: converse.md — RECOMMENDED tuning defaults, identity-gated response mode, pure updated_session channel - #107
spec: converse.md — RECOMMENDED tuning defaults, identity-gated response mode, pure updated_session channel#107JarbasAl wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 36 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…nse mode, pure updated_session channel Squashed from: - spec: converse.md — audit fixes: poll ceiling, reply-derived ping, selection order, inert response_mode - spec: OVOS-CONVERSE-1 — RECOMMENDED tuning defaults, identity-gated response mode, no in-place session mutation Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Consistency pass over
converse.md(OVOS-CONVERSE-1), in two groups.1. PR-original fixes
converse_handlers; a pruned or unrecognised holder is never delivered to."done"removal on a null return no longer mutates the inbound session in place; the PIPELINE-1 §4.2 channel discipline holds without exception.Matchslot map namedslotsper PIPELINE-1 §4.1.resulthere).2. Audit additions
Behaviour-relevant (implementers must read):
replyfrom the inbound utterance Message (MSG-1 §5.2). Previously unspecified; a plugin that emitted a bare Message would dropcontext.sessionand lose satellite routing.result⇒false; first valid pong per owner wins.activated_at", with the equal-timestamp tie-break resolved toward the entry nearest the head (PIPELINE-1 §7.1), and an explicit sequential/parallel equivalence statement.response_modeholder is exempt from TTL pruning and cap eviction. Without this, the 10-entry default cap could strand a live response window.Nconsecutive poll timeouts (RECOMMENDED 3), and SHOULD remove an owner onovos.skill.deregister(INTENT-4 §8.4).response_mode_helddropped (unreachable);timeoutmarked plugin-synthesised and never on the wire.Editorial / consistency:
response_modeentry is modelled as inert: it changes no routing decision, and is cleared by the plugin on its next claiming match or by the orchestrator when it commits anyupdated_session. No plugin mutation exception is created."done"pending removal is re-derived from the next poll round rather than remembered, so §9.2's no-cross-utterance-state rule stays intact.response_moderule deleted; OVOS-STOP-1 §6.1 cited as its owner.Dependency
The §4.1 tie-break cites PIPELINE-1 §7.1, where the equal-
activated_at"nearest the head" rule is defined once for the whole family. That sentence lands in the PIPELINE-1 PR, which merges before this one.