Skip to content

spec: gui-1.md — one player time convention; confirm/select reserved - #108

Open
JarbasAl wants to merge 1 commit into
devfrom
spec/gui-1
Open

spec: gui-1.md — one player time convention; confirm/select reserved#108
JarbasAl wants to merge 1 commit into
devfrom
spec/gui-1

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 4, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Fable 5 (claude-fable-5) via Claude Code — NOT human-reviewed. Verify before acting. Cross-spec citations were model-verified against dev source; behavior-change sections need owner judgment.

Refines OVOS-GUI-1 for internal purity, and closes several audit gaps found while cross-checking the spec family (rebased clean onto dev; no conflicts).

Changes

  • One time convention across the player templates: SYSTEM_audio_player position/duration now count in milliseconds with -1 = unknown/live, matching SYSTEM_media_player. Two templates sharing one screen role must not disagree on units; a normative paragraph states the uniform convention.
  • SYSTEM_confirm / SYSTEM_select → reserved for a future version (§3.4, §7.2). Their display leg is trivial, but the reply leg (interaction event carrying the answer) has no specified topic or payload schema — an unspecified reply makes the templates unimplementable interoperably. Names stay reserved so applications cannot claim them; producers MUST NOT emit them in this version. Conformance items referencing the reply leg removed (§8.1, §8.5).
  • __idle: explicit false row; omitted-__idle deployment default now carries a RECOMMENDED value (30 s) instead of being fully unspecified — tuning value, so RECOMMENDED, not MUST.
  • Undispatchable-template rule (§3.2): an unrecognised SYSTEM_-prefixed page name — reserved or simply unknown — is not a protocol error. It is the ordinary case §6.5 already covers: an adapter MUST NOT fail on it, and treats it as an undispatchable template (decline as a no-op, or degrade).
  • __from trust boundary (§4.1): __from MUST be the producer's own identifier. This spec defines no mechanism that verifies the claim — a forged __from can clear or mutate another producer's namespace. Enforcing the claim is named explicitly as a layer-2 trust-boundary concern (OVOS-MSG-1 §3.4), not something the GUI wire protocol itself can arbitrate.
  • Multi-page page_names/index lifecycle (§4.2): all entries of one gui.page.show belong to a single namespace; only the entry at index is active (§4.3 activation applies to it alone), the rest are held, not rendered; the active entry changes by re-emitting gui.page.show with a new index.
  • Session-scoping cross-reference (§3.3): cumulative session data is explicitly scoped per session_id, citing §4.3/§5.1.
  • Orphaned persistent namespaces (§4.3): a persistent (__idle: true) namespace whose producer vanishes without clearing it is not reclaimed by this specification — named as a deliberate simplicity trade-off (no producer-liveness tracking), cleanup left to deployer policy.
  • Version 1 → 2: mandating ms where the pre-spec status quo used seconds is not backwards compatible (VERSIONING.md).
  • CHANGELOG entry appended/extended under the class-2 section for all of the above.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d3cf0488-ad33-4d2e-8344-0dd98e6de06e

📥 Commits

Reviewing files that changed from the base of the PR and between 1d3622b and 7e31f5d.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • gui-1.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/gui-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Squashed from:
- spec: gui-1.md — trust boundary, multi-page lifecycle, undispatchable-template rule
- spec!: GUI-1 — one player time convention; confirm/select reserved

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant