spec: OVOS-PIPELINE-1 — audit fixes across match, policy and dispatch - #133
spec: OVOS-PIPELINE-1 — audit fixes across match, policy and dispatch#133JarbasAl wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 36 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Squashed from: - spec: OVOS-PIPELINE-1 — §7.3 suppressed-row count fixed - spec: OVOS-PIPELINE-1 — audit fixes across match, policy and dispatch Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
98795a3 to
a0ddead
Compare
Applies the PIPELINE-1 audit findings. Within-class refinement — the
spec stays at Version 2; CHANGELOG entry added under the existing
### 2heading.Behavior changes — needs owner sign-off
active_handlers. §7.3 gains anactivation push column, and
fallbackis marked notsuppressed. Previously every reserved name suppressed the push,
which left a fallback handler unreachable by OVOS-STOP-1 (it selects
its target from
active_handlers) and ineligible for a conversefollow-up. That is wrong for a long-running or conversational
fallback such as a language-model handler.
converse,response,stopandcommon_querystay suppressed.chain. §6.1 moves the compose step below TRANSFORM-1 §3.3 so a
metadata transformer that writes
session.pipelineroutes thecurrent utterance rather than the next one. CONVERSE-1 §3.3 relies
on per-utterance routing.
Blockers
plugin that does not filter "not conformant" while giving it only a
SHOULD. Plugin-side filtering is stated as an optimisation; the
orchestrator's per-candidate check is the enforcement, and §5.6's
authorization model is pinned to that tier alone.
session's
blacklisted_pipelines/blacklisted_skills/blacklisted_intentsonto any committedupdated_session. Withoutit any loaded plugin could grant itself and its successors the
permissions policy denied.
Matchrule replaces thelang-only one: missing or wrong-typed required fields, empty or
:-bearingskill_id/intent_name, non-BCP-47lang, nonstring→string
slots, emptyutterance. All are declinations, andthe orchestrator MUST NOT repair them.
Majors
Matchthatsurvives well-formedness, denylist and
required_slotschecks.(§5.5), not
session.pipelinedirectly.active_handlers,defined once:
activated_atauthoritative, equal timestampstie-break to the entry nearest the head. Consumers MUST NOT
define their own. STOP-1 §4.1 step 4 polarity is fixed in its own PR.
OVOS-COMMON-QUERY-1 §7.2, and the obligation is retargeted from the
orchestrator (which cannot see inside a black-box plugin) to the
deployment.
Matchreturned after the bound expired MUST beignored and MUST NOT be dispatched; cancellation stays out of
scope, and plugins SHOULD tolerate a discarded result. This
closes a double-dispatch path against the §9.5 invariant.
langis the resolved tag the round ran in, presentwhenever iteration ran, not entry-topic residue.
independent session copy, making the declined-plugin discard
enforceable rather than aspirational.
required_slotsbackstops,skill_id/pipeline_idstamping, theactive_handlerspush, the policy re-imposition, thetimed-out-
Matchrule and match-phase liveness; the plugin claimbullet now names
slotsandutterance.Minors
default-session pipeline of §5.1.
match round on both branches, before dispatch.
reconciled with §10.4 and §11; an empty
intentsarray is theanswer for a plugin with nothing loaded, since silence signals
"not loaded".
pipeline_idMUST match[A-Za-z0-9_-]..is nowexcluded alongside
:, because the identifier is a segment of thedot-separated §10.1 introspection topic.
terminates at the deployment default language, so
langis neverabsent at a
matchcall.Out of scope (other PRs)
common-query.md.stop-1.mdandconverse.md.appendix/divergences.md.GLOSSARY.md.Files touched:
pipeline-1.md,CHANGELOG.md.