Drop ExecReload from SystemD services - #145
Merged
Merged
Conversation
Sharpie
enabled auto-merge
September 4, 2026 05:41
Sharpie
disabled auto-merge
September 4, 2026 05:41
This commit removes `ExecReload=kill -HUP $MAINPID` from the SystemD service templates. Using `kill` to send `SIGHUP` is redundant when `Type=notify-reload` is set as SystemD will send the signal its self. SystemD also marks the service as "reloaded" if the `ExecReload` command exits with a success code. This can result in `systemctl reload` returning early, before the service is ready to accept traffic. Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
Sharpie
force-pushed
the
drop-execreload-kill
branch
from
September 4, 2026 05:42
9ffd484 to
34264e2
Compare
Sharpie
enabled auto-merge
September 4, 2026 05:43
bastelfreak
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This commit removes
ExecReload=kill -HUP $MAINPIDfrom the SystemD service templates. Usingkillto sendSIGHUPis redundant whenType=notify-reloadis set as SystemD will send the signal its self.SystemD also marks the service as "reloaded" if the
ExecReloadcommand exits with a success code. This can result insystemctl reloadreturning early, before the service is ready to accept traffic.This Pull Request (PR) fixes the following issues