feat: add OpenVox View dashboard alongside Puppetboard#20
Conversation
|
I have to say i prefer this implementation method as it allows users the choice and allows us a transition path (e.g. leave puppetboard default, then switch to openvoxview as default, then later remove puppetboard) @JGodin-C2C wanting to draw your attention to this for any input you may wish to add I haven't reviewed yet but please ensure that default remains puppetboard at this time |
anthonysomerset
left a comment
There was a problem hiding this comment.
I am happy with the change, please update the unit tests and bump the version number like other merged changes and push to this PR
|
Yep, overall the MR seems solid ( i left a comment, but that kinda splinting hairs ) .
So, kudos for the new code. |
|
I have made the suggested changes, please have a look. |
|
Hi @anthonysomerset , checking in on this. Thanks! |
|
I'm somewhat blocked by #22 to be cleared as this will resolve the testing fails here - have re-requested a review as i can't review my own PR and merge it :) |
|
approving the PR but merging is blocked as Commits need to have verified signatures fastest solution that works for me is to rebase all your commits down to one once you've verified commit signing is setup and enabled in your environment, then force push back to the branch - that should also trigger CI again which should pass |
7c44bd1 to
55107dd
Compare
55107dd to
71d1ee7
Compare
71d1ee7 to
d44375c
Compare
Add optional OpenVox View sidecar on PuppetDB with service and ingress support, keep Puppetboard as default, add helm unit tests, and bump chart version to 10.0.3. Signed-off-by: Shubh Gaur <sratslla@gmail.com>
d44375c to
b05b92a
Compare
Fixes #19
Summary
PR sponsored by Obmondo.com
Note: Since this is a company-paid contribution, we fork to the company account repo on GitHub. GitHub does not support "allow maintainer to edit in repo" for organization accounts.