Skip to content

Remove unused cross compilation logic#179

Merged
nmburgan merged 4 commits into
mainfrom
solaris
May 15, 2026
Merged

Remove unused cross compilation logic#179
nmburgan merged 4 commits into
mainfrom
solaris

Conversation

@bastelfreak
Copy link
Copy Markdown
Contributor

Short description

Checklist

I have:

@bastelfreak bastelfreak self-assigned this May 14, 2026
Comment thread configs/components/augeas.rb
Comment thread configs/components/ruby-3.2.rb
Comment thread configs/components/ruby-3.2.rb
Copy link
Copy Markdown

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastelfreak
Copy link
Copy Markdown
Contributor Author

FYI I pulled the powerpc removal into a dedicated PR: #180

@nmburgan
Copy link
Copy Markdown
Member

How much of https://github.com/OpenVoxProject/puppet-runtime/blob/main/notes/cross-compiling.md is still relevant?

Some of it is relevant if we ever have to go the cross compilation route again (I really only forsee us doing that for MacOS x86_64 if we really have to after they remove Rosetta), but we aren't currently doing it at all.

@bastelfreak bastelfreak changed the title Remove unused cross compilation logic & Remove all PowerPC leftovers Remove unused cross compilation logic May 14, 2026
Copy link
Copy Markdown

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many of the mentions of /opt/pl-build-tools are still relevant after we drop cross compiling?

Comment thread configs/components/libffi.rb Outdated
@nmburgan
Copy link
Copy Markdown
Member

Definitely all instances of pl-build-tools references we can remove

Comment thread configs/components/virt-what.rb Outdated
@bastelfreak bastelfreak force-pushed the solaris branch 2 times, most recently from 113591c to abc55b8 Compare May 14, 2026 21:42
Comment thread configs/components/virt-what.rb
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
this was only used for cross compilation

Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Signed-off-by: Tim Meusel <tim@bastelfreak.de>
@bastelfreak
Copy link
Copy Markdown
Contributor Author

A full compilation for also windows and macos: https://github.com/OpenVoxProject/puppet-runtime/actions/runs/25935830927

Comment thread configs/components/augeas.rb
@bastelfreak bastelfreak force-pushed the solaris branch 2 times, most recently from 39c6c9a to d6dd2b6 Compare May 15, 2026 19:37
@nmburgan nmburgan merged commit 4e7a39d into main May 15, 2026
77 checks passed
@nmburgan nmburgan deleted the solaris branch May 15, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants