Review: the four RI architecture reports, round 2 (comments only, do not merge) - #40
Open
pepebndc wants to merge 2 commits into
Open
Review: the four RI architecture reports, round 2 (comments only, do not merge)#40pepebndc wants to merge 2 commits into
pepebndc wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
A review-only PR to collect a fresh round of external comments on the four OpenZeppelin Canton Reference Implementation (RI) architecture reports, as they currently stand on
main(including the refinements merged since the first round). The base branch is a temporary copy ofmainwith the reports removed, so the full text of each report appears here as an added-file diff and supports inline comments.Do not merge. The reports already live on
mainunderdocs/ri-reports/. When this review round is done the PR will be closed and the temp branches deleted.The previous round was collected in #26, now closed.
Files under review
docs/ri-reports/01-dex.md(Privacy-Preserving DEX)docs/ri-reports/02-lending.md(Lending Protocol)docs/ri-reports/03-cross-chain-stablecoin.md(Cross-Chain Stablecoin)docs/ri-reports/04-confidential-auction.md(Confidential Auction Launchpad)docs/ri-reports/README.md(index and shared foundation for all four)How to review
Open the Files changed tab and leave inline comments directly on the report lines. General remarks are welcome as regular PR comments.
🤖 Generated with Claude Code