fix: fetch every attachment of a page when downloading images - #35
Merged
Merged
Conversation
blaipr
force-pushed
the
fix/page-attachments
branch
from
September 2, 2026 22:39
4b01eb1 to
f4c8113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
download_pagefetched a page's attachments with a singleget_attachments_from_content(page_id, limit=250)call. Confluence Cloud caps that endpoint's page size well below 250 and signals the remainder only through_links.next, which was never followed. On a page with more attachments than one server page, every image referencing an attachment past the cap was reported asattachment not found on pageand skipped, leaving a dangling image link in the Markdown.Change
A new
get_page_attachments(client, page_id)fetches the list page by page, mirroringget_child_pages: it follows_links.nextwhen the response is a dict (and pages by count when an older client returns a plain list), advancingstartby the number of results actually returned so a server-applied smaller page size is handled.download_pagebuilds its title lookup from the full list.Compatibility
Download only. Pages with few attachments behave as before (one request); pages with many now download all their referenced images.
Checklist
ruff check src tests,ruff format --check src testsandpython -m pytest tests/passtests/test_attachments.py)docs/conversion.md— not needed, no equivalence changedCHANGELOG.mdupdated under Unreleased