fix: read a leading h1 title with no newline after it - #37
Merged
Merged
Conversation
blaipr
force-pushed
the
fix/leading-h1-at-end-of-file
branch
from
September 2, 2026 22:40
2bb7315 to
d3f5e54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
split_leading_h1matched\s*#\s+(.+?)\s*\n+, so a Markdown file consisting of a heading with nothing after it and no trailing newline (# My Page) was not recognised as titled. Inupload --recursivesuch a file took its title from the filename (My_Page) and the heading stayed in the body, duplicated under the page title.Change
The pattern now also accepts end of input after the heading:
\s*#\s+(.+?)\s*(?:\n+|\Z). Files with a body, without an h1, or starting with a deeper heading behave as before.Compatibility
Upload only; no change for files that end with a newline.
Checklist
ruff check src tests,ruff format --check src testsandpython -m pytest tests/passtests/test_recursive_upload.py::TestSplitLeadingH1)docs/conversion.md— not needed, no equivalence changedCHANGELOG.mdupdated under Unreleased