Skip to content

fix: Correct display issues in orange compact components and accessibility issues#637

Open
nouha06 wants to merge 5 commits intodevelopfrom
630-bug-orange-compact-some-components-are-not-displayed-correctly
Open

fix: Correct display issues in orange compact components and accessibility issues#637
nouha06 wants to merge 5 commits intodevelopfrom
630-bug-orange-compact-some-components-are-not-displayed-correctly

Conversation

@nouha06
Copy link
Copy Markdown
Member

@nouha06 nouha06 commented Mar 30, 2026 •
edited
Loading

  • Update accessible name for show/hide button in Password Input
  • Ensure hidden passwords are read clearly by screen readers
  • Fix label for Suggestion Chip
  • Add button role to Filter Chip
  • Add role to Pin Code Input digit input
  • Read helper text with group label in Pin Code Input

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

closes - #630 #599 #494 #488 #519 #482 #486 #487

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@nouha06
fix: address various accessibility and display issues in library comp…
641e49f 
…onents

- Correct display issues in `orange compact` components
- Update accessible name for show/hide button in `Password Input`
- Ensure hidden passwords are read clearly by screen readers
- Fix label for `Suggestion Chip`
- Add button role to `Filter Chip`
- Add role to `Pin Code Input` digit input
- Read helper text with group label in `Pin Code Input`
@nouha06 nouha06 linked an issue Mar 30, 2026 that may be closed by this pull request
[Bug]: orange compact some components are not displayed correctly #630
Open
11 tasks
@nouha06 nouha06 requested a review from AhmedAmineZr March 30, 2026 14:34
@nouha06 nouha06 self-assigned this Mar 30, 2026
@AhmedAmineZr
Copy link
Copy Markdown
Member

AhmedAmineZr commented Mar 31, 2026

i tested this PR in This Figma File : https://www.figma.com/design/uSn87CFTOK1zRcyGBuUAOz/Review---Flutter?node-id=21-403

@nouha06 nouha06 marked this pull request as ready for review March 31, 2026 15:40
AhmedAmineZr
AhmedAmineZr reviewed Mar 31, 2026
View reviewed changes
@nouha06
Merge branch 'develop' into 630-bug-orange-compact-some-components-ar…
09f6d34 
…e-not-displayed-correctly

# Conflicts:
#	app/CHANGELOG.md
#	ouds_core/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AhmedAmineZr AhmedAmineZr AhmedAmineZr approved these changes

Assignees

@nouha06 nouha06

Labels

👂 accessibility 🐞 bug Something isn't working 🧰 library ⌛ validations awaiting fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: orange compact some components are not displayed correctly

2 participants

@nouha06 @AhmedAmineZr