Read full 32bits at correct GPIO address and correct some pin mappings.#6
Open
ashdriver wants to merge 2 commits intoOrangePiLibra:masterfrom
Open
Read full 32bits at correct GPIO address and correct some pin mappings.#6ashdriver wants to merge 2 commits intoOrangePiLibra:masterfrom
ashdriver wants to merge 2 commits intoOrangePiLibra:masterfrom
Conversation
bank 3, GPIOD (pins 96-127) still have an issue I think. Havent tested all pins on other buses either, but this is a definite improvement on what was there before.
ashdriver
commented
Dec 7, 2017
Author
ashdriver
left a comment
ashdriver
left a comment
There was a problem hiding this comment.
Reverted pin mapping to match original scheme which had its own logic. Enabled bus2 / GPIOC as it seems to work OK now, at least as input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is for the Orange Pi 2G IOT. Previously the GPIO registers were being dereferenced as 8bit instead of 32 bit values, so only lines 0-7 were accessable. Also many pin mappings were incorrect.
Bank 3, GPIOD (pins 96-127) still has an issue I think. I haven't tested all pins on other buses either, but this is a definite improvement on what was there before.