Skip to content

chore: guard audit and deny tooling#65

Open
dangelo352 wants to merge 1 commit into
OrbitChainLabs:mainfrom
dangelo352:fix/audit-deny-tooling-46
Open

chore: guard audit and deny tooling#65
dangelo352 wants to merge 1 commit into
OrbitChainLabs:mainfrom
dangelo352:fix/audit-deny-tooling-46

Conversation

@dangelo352

Copy link
Copy Markdown

Closes #46

Summary

  • Add clear preflight checks to make audit and make deny for missing cargo-audit / cargo-deny.
  • Document the install commands in README and a new contributor guide.
  • Add CI jobs that install cargo-audit and cargo-deny before running the Makefile targets.
  • Include audit/deny in make help.

Validation

  • git diff --check
  • Parsed .github/workflows/ci.yml with Ruby YAML loader
  • Verified missing-tool behavior locally:
    • make audit prints cargo-audit not installed. Run 'cargo install cargo-audit --locked' then retry. and exits non-zero
    • make deny prints cargo-deny not installed. Run 'cargo install cargo-deny --locked' then retry. and exits non-zero

I did not run the positive audit/deny paths because cargo-audit and cargo-deny are intentionally not installed in this local environment; CI now installs them before running those checks.

Alqku commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Hi @dangelo352 👋 — appreciate the audit/deny tooling hardening on #46. Two things block the merge here: (1) issue #46 isn't currently assigned to anyone, so I can't merge under our contributor-matches-assignee policy; (2) the Dependency policy CI check is failing (likely a fresh cargo deny advisory). Please ping a maintainer to assign #46 to you, fix the deny warning(s), and push. Happy to merge once both are sorted 🙏

@GBOYEE

GBOYEE commented Jun 24, 2026

Copy link
Copy Markdown

I'd like to work on this.

Approach:

  • I'll add the CI config and test it locally before pushing
  • Verify with existing tests + add new ones if needed

Estimated effort: ~1-2 hours. PR incoming shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LOW] Makefile audit/deny targets fail opaquely when cargo-audit/cargo-deny are not installed

3 participants