fix: resolve model switch UI freeze on edge cases#47
Open
NSIETeam wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix: Model switch UI freeze on edge cases
Problem
Users experience the model selector UI permanently showing "Switching..." in two scenarios:
switchModel() throws an exception: The catch block sends
sendModelResponse({success:false})but does NOT sendmodel_switch_complete. The frontend'sisModelSwitchingflag is only cleared whenmodel_switch_completeis received, so the UI gets stuck.geminiClient is null: When
geminiClientis unavailable butconfig.setModelexists, the model is switched successfully but nomodel_switch_completeevent is emitted, leaving the frontend out of sync.Fix
Fix 1 (
extension.tscatch block): AddedsendModelSwitchComplete()call in the catch block ofonSetCurrentModelhandler, so the frontend clearsisModelSwitchingeven on failure.Fix 2 (
extension.tsconfig.setModel path): AddedsendModelSwitchComplete()call afterconfig.setModel(), ensuring the frontend is notified when the model is switched via the config fallback path.Files Changed
packages/vscode-ui-plugin/src/extension.ts(+6 lines)Testing
model_switch_complete