Minor cleanup/refactor of some logic#118
Open
LahaLuhem wants to merge 2 commits intoOutdatedGuy:mainfrom
Open
Conversation
OutdatedGuy
requested changes
Jan 31, 2026
Owner
OutdatedGuy
left a comment
There was a problem hiding this comment.
Lots of unnecessary formatting changes. Please revert them first.
618624f to
14eab66
Compare
Author
|
You have not defined any kind of formatting guidelines. The code is not even formatted, as these kinds of changes would appear if you'd just run dart format .. |
Author
|
@OutdatedGuy I have reverted most of the formatting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some improvements:
_checkReachabilityFor: use null assertion operator for cleaner code_hasInternetAccessNonStrict: added try-catch to handle individual endpoint failures gracefullyI did this in the context to be better be able to support the new feature request in #71