feat(skills): add api-design skill and plugin manifest - #17
Merged
Conversation
ms-shashank
force-pushed
the
feat/api-design-skill
branch
from
August 31, 2026 08:06
bb0233d to
ffc138c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
Summary
Adds the
api-designskill to review public interfaces (HTTP/REST endpoints, GraphQL schemas, RPC methods, SDK functions, and exported module types) before they become expensive breaking changes after release.PR Requirements Checklist (per
CONTRIBUTING.md)1. Task Tested & Before vs. After
Task: Reviewing a newly added
POST /api/v1/transfersendpoint and aGET /api/v1/transferslist endpoint.Before (Default model review):
After (With
/api-design):apps/webandservices/worker, grounding all findings in concrete caller impact.2. What was Deliberately Left Out (and Why)
Internal implementation reviews: Omitted critiques of internal helper functions, local algorithms, and database queries because private implementation can be refactored at any time without breaking downstream callers.
Speculative protocol additions: Omitted generic suggestions for alternative architectures (e.g. gRPC/WebSockets) to avoid noise and focus strictly on the interface contract at hand.
Linter/formatting nits: Delegated formatting and syntax styling to automated formatters.
3. Tools Matching
tools: chat(read-only) because interface review is a pure evaluation task that does not mutate files or execute commands.