[WIP] Pdok 18835/vervanging trex#40
Conversation
kad-korpem
left a comment
kad-korpem
left a comment
There was a problem hiding this comment.
Nog even naar de linting errors kijken (vooral code style en type safety dingetjes zo te zien)
a6e3eb6 to
153afac
Compare
RoelvandenBerg
left a comment
RoelvandenBerg
left a comment
There was a problem hiding this comment.
Nice! Klein dingetje.
Had je de go styleguide al gelezen? Zo nee dan is dat een goeie om te doen.
| return quadrantI & right | ||
| // A version of Amanatides-Woo | ||
| // Concept: parametrize line with parameter t, with t = 0 being the start and t = 1 the endpoint. Then compute the t for which tile boundaries are intersected. By taking a suitable multiple of t, this is guaranteed to be integral. Use these to raycast along the tiles. | ||
| func (ix *PointIndex) AmanatidesWoo(line geom.Line, l Level, ringIdx int, pointIdx int) { |
There was a problem hiding this comment.
Ik stel voor deze CellTraversal te noemen oid. (geen FastCellTraversal (dat was mijn eerste voorstel obv AmantidesWoo) want dat is een finalBattleMostDangerousBossMonster, via)
There was a problem hiding this comment.
Ben je van plan deze buiten de pointindex / dit package te gebruiken? CamelCase is voor exported identifiers, pascalCase voor de rest.
|
Pull request closed: development continues on other branch, see #42 . Preserving this branch for future referencing of this code. |
3 participants
Description
This is a work in progress on tile generation within
texel. This feature is not yet finished. Now implemented is:Type of change
Checklist: