Conversation
1) Decrease usage of Obj module for explicitness 2) Move logic variable related helpers into module Var 3) Fix possible bug with immutable anchor. OCaml's physical equality doesn't guarantee pointer equality for immutable types for optimisation reasons Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Seems like 'Disequality.reify' cannot return empty answer on well-formed constraint Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Kakadu
approved these changes
Jun 14, 2025
Collaborator
Kakadu
left a comment
Kakadu
left a comment
There was a problem hiding this comment.
I think that these changes are correct but formatting changes are doubtful.
In general, we should integrate autoformatting on non-camlp5 files, but let's postpone it for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly just syntactical changes without semantical, but there are some significant:
Term.ml: Fix possible bug with immutable anchor. OCaml's physical equality doesn't guarantee pointer equality for immutable types for optimisation reasonsEnv.ml: Fix immediate add after removing from map on the same keyCore.ml: Add assertion on empty answer in State.reify. Seems like 'Disequality.reify' cannot return empty answer on a well-formed constraintCore.ml: Replace variable list with variable set in State.reify. I believe it mustn't slow down reification but only speed it up