🩹 [Patch]: Name the helper module after the action (Resolve-PSModuleVersion.Helpers)#8
Open
Marius Storhaug (MariusStorhaug) wants to merge 1 commit into
Open
Conversation
Aligns with the action helper-module naming standard: name the module after the action, not the generic Helpers (which collides with the shared framework Helpers module in the runner's single module session). Renames scripts/ResolveVersion.psm1 (interim name from #4) and its test files, and updates the entry-script import plus test -ModuleName references. No runtime logic changed. Part of PSModule/Process-PSModule#364.
Copilot started reviewing on behalf of
Marius Storhaug (MariusStorhaug)
July 9, 2026 11:12
View session
There was a problem hiding this comment.
Pull request overview
This PR aligns the action’s helper module naming with the established <Action>.Helpers convention by renaming the helper script module and updating all internal references (entry script + tests) accordingly.
Changes:
- Renamed the helper module to
Resolve-PSModuleVersion.Helpersand updated the entry script import (scripts/main.ps1). - Renamed the Pester test file and test data file, updating their import paths.
- Updated Pester
Mock -ModuleNamereferences to match the new module name.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/Resolve-PSModuleVersion.Helpers.psm1 | Helper module now lives under the convention-based name (Resolve-PSModuleVersion.Helpers). |
| scripts/main.ps1 | Imports the renamed helper module script. |
| tests/Resolve-PSModuleVersion.Helpers.Tests.ps1 | Updates test data/module imports and Mock -ModuleName to the new helper module name. |
| tests/Resolve-PSModuleVersion.Helpers.Tests.Data.psd1 | Test data file renamed to match the updated test/module naming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the helper module with the action helper-module naming standard: name it after the action (
Resolve-PSModuleVersion.Helpers) instead of a generic name.PR #4 introduced the interim name
ResolveVersionto fix theHelperscollision; this brings it to the ecosystem-wide convention (<Action>.Helpers) now that the standard is in place.Changes
scripts/ResolveVersion.psm1→scripts/Resolve-PSModuleVersion.Helpers.psm1tests/ResolveVersion.Tests.ps1→tests/Resolve-PSModuleVersion.Helpers.Tests.ps1tests/ResolveVersion.Tests.Data.psd1→tests/Resolve-PSModuleVersion.Helpers.Tests.Data.psd1scripts/main.ps1), the test module import, the test data-file path, and the twoMock -ModuleNamereferences. Kept the frameworkImport-Module -Name 'Helpers'.No runtime logic changed (100% file rename + reference updates).
Validation
Tests pass 131/131 under a simulated
Helpersname collision (a second module namedHelpersloaded before Invoke-Pester). PSScriptAnalyzer clean apart from the pre-existingPSAvoidUsingWriteHostwarnings (unchanged module body).Part of PSModule/Process-PSModule#364. Standard: the "Name helper modules after the action" rule in the GitHub Actions coding standard (MSXOrg/docs#24).