Skip to content

🩹 [Patch]: Name the helper module after the action (Resolve-PSModuleVersion.Helpers)#8

Open
Marius Storhaug (MariusStorhaug) wants to merge 1 commit into
mainfrom
maintenance/rename-helper-module
Open

🩹 [Patch]: Name the helper module after the action (Resolve-PSModuleVersion.Helpers)#8
Marius Storhaug (MariusStorhaug) wants to merge 1 commit into
mainfrom
maintenance/rename-helper-module

Conversation

@MariusStorhaug

Copy link
Copy Markdown
Member

Aligns the helper module with the action helper-module naming standard: name it after the action (Resolve-PSModuleVersion.Helpers) instead of a generic name.

PR #4 introduced the interim name ResolveVersion to fix the Helpers collision; this brings it to the ecosystem-wide convention (<Action>.Helpers) now that the standard is in place.

Changes

  • scripts/ResolveVersion.psm1scripts/Resolve-PSModuleVersion.Helpers.psm1
  • tests/ResolveVersion.Tests.ps1tests/Resolve-PSModuleVersion.Helpers.Tests.ps1
  • tests/ResolveVersion.Tests.Data.psd1tests/Resolve-PSModuleVersion.Helpers.Tests.Data.psd1
  • Updated the entry-script import (scripts/main.ps1), the test module import, the test data-file path, and the two Mock -ModuleName references. Kept the framework Import-Module -Name 'Helpers'.

No runtime logic changed (100% file rename + reference updates).

Validation

Tests pass 131/131 under a simulated Helpers name collision (a second module named Helpers loaded before Invoke-Pester). PSScriptAnalyzer clean apart from the pre-existing PSAvoidUsingWriteHost warnings (unchanged module body).

Part of PSModule/Process-PSModule#364. Standard: the "Name helper modules after the action" rule in the GitHub Actions coding standard (MSXOrg/docs#24).

Aligns with the action helper-module naming standard: name the module after the action, not the generic Helpers (which collides with the shared framework Helpers module in the runner's single module session). Renames scripts/ResolveVersion.psm1 (interim name from #4) and its test files, and updates the entry-script import plus test -ModuleName references. No runtime logic changed. Part of PSModule/Process-PSModule#364.
Copilot AI review requested due to automatic review settings July 9, 2026 11:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the action’s helper module naming with the established <Action>.Helpers convention by renaming the helper script module and updating all internal references (entry script + tests) accordingly.

Changes:

  • Renamed the helper module to Resolve-PSModuleVersion.Helpers and updated the entry script import (scripts/main.ps1).
  • Renamed the Pester test file and test data file, updating their import paths.
  • Updated Pester Mock -ModuleName references to match the new module name.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/Resolve-PSModuleVersion.Helpers.psm1 Helper module now lives under the convention-based name (Resolve-PSModuleVersion.Helpers).
scripts/main.ps1 Imports the renamed helper module script.
tests/Resolve-PSModuleVersion.Helpers.Tests.ps1 Updates test data/module imports and Mock -ModuleName to the new helper module name.
tests/Resolve-PSModuleVersion.Helpers.Tests.Data.psd1 Test data file renamed to match the updated test/module naming.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants