Drop unused GM workspace from rms_norm_binary - #72
Conversation
Binary-accumulation cache now lives in a Local tile array, so dyn/static entries no longer take a workspace pointer or host buffer. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 465fd5dd7f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| constexpr int kWsCols = 128; | ||
| constexpr int kMaxLevels = 6; | ||
| constexpr int kWsCols = 32; |
There was a problem hiding this comment.
Keep float vector tiles at the 512-byte minimum
With kWsCols = 32, every tile_v used by TROWSUM, TADD, TMULS, TRECIP, and TROWEXPANDMUL has only 128 bytes of physical capacity. The one-level TileOP normalization kernels require a float scalar/broadcast strip of at least 128 columns (512 bytes), as documented and implemented in rms_norm/rms_norm_pto.hpp and both group-norm-grad kernels; therefore the dynamic and static rms_norm_binary paths can compile but fail during functional execution with an invalid active size/Match Instruction error. Retain 128 physical columns while keeping ValidCol=1.
Useful? React with 👍 / 👎.
Summary
updateTile[]) instead of GMworkspace.workspaceargument from both dyn and staticrms_norm_binaryentries, and drop the matching host buffers in the test mains.Test plan
make TESTCASE=rms_norm_binary DType=__halfcompilesmake TESTCASE=rms_norm_binary_static DType=__half G_A=1 G_R=8192 TILE_A=1 TILE_R=1024 POW_R=4096compiles[1,8192]if CI/reviewer wants a functional re-checkMade with Cursor