feat(gfsim): add committed replay with source names and selectable Table trees - #79
Open
hmljy2020 wants to merge 8 commits into
Open
feat(gfsim): add committed replay with source names and selectable Table trees#79hmljy2020 wants to merge 8 commits into
hmljy2020 wants to merge 8 commits into
Conversation
Add opt-in replay recording with topology, typed state snapshots, token identities and atomic operation events (Decision 0223). Keep HTML generation in an independent, uncommitted tool package. Evidence: docs/gates/logs/20260908-queue-table-flow/. ROB and native checks pass; existing Queue codegen failures and historical missing decision evidence are documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Record committed Queue/Table dataflow in
PYC6TRC3and render it in an offline viewer. Lightweight observation hooks preserve atomic commit boundaries and keep replay state outside ordinary components.Preserve frontend rule/module names through verified
ac.source_namemetadata into gfsim replay labels, with canonical identities retained. Render nested Table fields with collapsible grouped headers and selectable fields and original row indices. Selections survive playback and seeking; hidden changes offer a reveal action and typed details preserve exact integer widths.Include DavinciOO ROB contracts, single/dual-flow test drivers, an allocation NDF draft and local validation evidence. At the author's explicit request,
designs/davincioo/spe/ooo/rob.pyis excluded from this submission and remains local. The new ROB tests require that missing module and cannot be reproduced from this PR checkout alone. The ROB evidence describes the complete local working tree, not a self-contained ROB delivery in this PR.pyc6 Decision / Contract Impact
Validation
f17b5ab1(run34199377528); the new head requires fresh CI:G0: Python ChecksG0: Agentic Python Checksrob.py./home/lc/.codex/skills/pyc6/scripts/run.shfor the fixed environment.docs/gates/logs/20260908-replay-main-migration/docs/gates/logs/20260908-davincioo-rob/docs/gates/logs/20260908-source-names/docs/gates/logs/20260908-single-rob/docs/gates/logs/20260908-table-tree/Documentation
Update the observation contract, standalone viewer README, source-name decision/status evidence, DavinciOO ROB/CMT interface contracts and module checklist. The NDF allocation example remains a draft; local ROB completion claims in archived evidence do not imply the excluded implementation is delivered remotely.
Risk / Compatibility
rob.pyand unrelatedenv.mdare excluded from Git.Related Issues
No automatic issue closure; upstream #70 and #73–#78 remain preserved by the existing merge.