Conversation
Warriorrrr
reviewed
May 22, 2026
Warriorrrr
left a comment
Warriorrrr
left a comment
Member
There was a problem hiding this comment.
I don't think this is the best way to resolve this, it would seem better to me to update the check in readModernModifications to avoid setting FORMAT_CHANGED to true if both the original renderer and the new renderer are default ones
github-project-automation
Bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
Warriorrrr
approved these changes
Aug 1, 2026
papermc-projects
Bot
moved this from Changes required
to Delayed approval
in Paper PR Queue
Warriorrrr
added
type: bug
Contributor
|
Alternatively this could be solved if defaultRenderer didn't always created a new instance. |
Member
|
I don't think we could really do that without making it not use ViewerUnawareImpl, a single instance of that can't be re-used multiple times since it caches the message after it's used once |
Contributor
|
or doing something like 1fd5542 |
papermc-projects
Bot
moved this from Delayed approval
to Full approval
in Paper PR Queue
Member
I see what you mean, I think that'd be nice |
Axyss
force-pushed
the
fix/chat-renderer-name-duplication
branch
from
September 29, 2026 18:37
78d358c to
154633d
Compare
Warriorrrr
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13574
Explicitly setting the default renderer caused chatTypeKey to be
ChatType.CHAT, which rendered the username again on the client.