Skip to content

A collection of small fixes#14002

Open
NewwindServer wants to merge 40 commits into
PaperMC:mainfrom
NewwindServer:fixes
Open

A collection of small fixes#14002
NewwindServer wants to merge 40 commits into
PaperMC:mainfrom
NewwindServer:fixes

Conversation

@NewwindServer

Copy link
Copy Markdown
Contributor

Some random issues I have found so far while working on updating Newwind to 26.2:

  • EntitySpawnEvent is called twice for XP orbs.
  • Non-savable passengers can save even if miscSerialization isn't allowed because its checking the wrong entity.
  • CraftCreatureSpawner uses maxInclusive twice instead of minInclusive.
  • PaperWrittenBookContent.asBook() uses requireNonNull wrongly.
  • PaperConsumable data component toBuilder() doesn't include hasConsumeParticles.
  • BukkitBrigForwardingMap wrongly returns early (probably doesn't matter though)
  • SizeLimitedSet is off by one (basically inconsequential)
  • Vanilla world migration (probably?) doesn't clear legacy PDC properly because dynamics are immutable.
  • "changed" and "clicked" are swapped in PlayerBucketFillEvent (you might wanna keep this one as is incase it breaks existing plugins idk)
  • PlayerShearEntityEvent drops weren't actually immutable.
  • There are some typos and missing closing curly brackets/apostrophes.

@NewwindServer NewwindServer requested a review from a team as a code owner June 28, 2026 22:40
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Jun 28, 2026
Comment thread paper-api/src/main/java/org/bukkit/RegionAccessor.java Outdated
Comment thread paper-server/src/main/java/io/papermc/paper/registry/HolderableBase.java Outdated
Comment thread paper-server/src/main/java/io/papermc/paper/registry/PaperRegistryAccess.java Outdated
Comment thread paper-server/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java Outdated
Comment thread paper-api/src/main/java/org/bukkit/event/entity/AreaEffectCloudApplyEvent.java Outdated
Comment thread paper-server/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

3 participants