Run DataFix WorldGenSettingsFix as LEVEL instead of WORLD_GEN_SETTINGS - #14190
Open
bergerkiller wants to merge 1 commit into
Open
Run DataFix WorldGenSettingsFix as LEVEL instead of WORLD_GEN_SETTINGS#14190bergerkiller wants to merge 1 commit into
bergerkiller wants to merge 1 commit into
Conversation
Fixes a problem where this fix runs after LevelDatToSavedDataPreparationFix, breaking migrations Signed-off-by: Irmo van den Berge <irmo.vandenberge@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run into a problem with an old format level.dat, that the MapFeatures level.dat value did not get properly migrated on Paper. It turned into generate_features, instead of generate_structures. This causes structures to be generated in the world when that was not intended.
I narrowed the problem down to the datafixer running out-of-order. The versioning made it appear this should not happen.
My hypothesis was that this was because these fixes run on the WORLD_GEN_SETTINGS schema, which is something that only exists after the world_gen_settings.dat split even exists. So as a result, it would only run late, after the generate_features > generate_structures rename already occurred.
I've tried rewriting it to use LEVEL, like the other fix, inspired by
LevelLegacyWorldGenSettingsFix. And that has fixed this problem for me.I do not know what other impacts this has, because I have limited understanding of datafixers.
In my_void_world_bu.zip is an empty world file with just level.dat, that when loaded, is transformed into the incorrect syntax.
my_void_world_bu.zip