Draft
Conversation
jpenilla
force-pushed
the
check-for-nested-path
branch
from
5994428 to
a1c260a
Compare
MiniDigger
requested changes
Mar 29, 2024
Member
There was a problem hiding this comment.
doesn't work:
we might have to check git settings and registry (via reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem /v LongPathsEnabled or powershell Get-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" -Name "LongPathsEnabled")
or we need to git add the file (--f --dry-run)
I also found precedent on github for just checking if path > 240 or > 255 (the android gradle plugin does this for example)
Contributor
|
would it be feasible and/or better to configure the git local repo config during the repo fetch process to allow long paths so this isnt an issue? especially since you don’t need to enable long paths in the registry for them to work, you only need the git setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check registry and git configs to see if long paths are likely to be a problem, and print a warning if so.