feat: expose configuration to fail on invalid ATs, closes #344#376
feat: expose configuration to fail on invalid ATs, closes #344#376Toffikk wants to merge 5 commits intoPaperMC:mainfrom
Conversation
Toffikk
force-pushed
the
feat/fail-on-invalid-ats
branch
from
2a434a1 to
c156df8
Compare
|
lmk if this is something that perhaps should be attached to the |
Toffikk
force-pushed
the
feat/fail-on-invalid-ats
branch
from
b8dba00 to
adf6f62
Compare
| outputPath, | ||
| atFile.path, | ||
| atWorkingDir.path, | ||
| validate = validateAts.get(), |
There was a problem hiding this comment.
This is guaranteed not to fail as this piece of code won't run if there is no at file specified and right now if the at file gets specified, this property also gets set.
The property was marked as optional due to the setupMacheResources task which uses the same task but doesn't specify ATs and i saw no point in wiring the validation property to it if no ats are gonna be applied anyway.
| at, | ||
| temporaryDir.toPath().resolve("jst_work"), | ||
| singleFile = true, | ||
| validate = false, |
There was a problem hiding this comment.
should this be made to always validate? the new AT lines should never be inapplicable but if such a situation were to happen it would be nice for it to blow up during saving them instead of failing during apply
| action.execute(updatingMinecraft) | ||
| } | ||
|
|
||
| val validateAts: Property<Boolean> = objects.property<Boolean>().convention(false) |
There was a problem hiding this comment.
maybe it'd be good for this to be on by default?
1 participant
No description provided.