security: timing-safe HMAC and CORS wildcard fix#617
Open
wahh3b-lgtm wants to merge 1 commit into
Open
Conversation
- Use hmac.compare_digest with bitwise OR for constant-time JWT signature verification - Reject wildcard CORS origins when allow_credentials=True - Fix Python 2 exception syntax (except TypeError, ValueError -> except (TypeError, ValueError))
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
app/utils/jwt.py): Replacedinmembership check withhmac.compare_digestusing bitwise OR to ensure both comparisons always execute, preventing timing side-channelsapp/middlewares/__init__.py): Whenallow_credentials=True, any wildcard origin (*) in the allowed origins list now disables credentials with a warningapp/utils/jwt.py): Fixedexcept TypeError, ValueError:toexcept (TypeError, ValueError):What was removed (per project owner feedback)
get_secret_key: The JWT secret key is permanent and doesn't need a TTLinvalidate_secret_key_cache: Unused function removedFiles Changed
app/utils/jwt.pyapp/middlewares/__init__.pyVerification