Revert dependency checks pending human review - #37
Closed
Pascal-Kueng wants to merge 2 commits into
Closed
Conversation
* Check development glmmTMB and brms compatibility * Limit development backend installs to required dependencies * Declare workshop SVG rendering dependency * Keep temporary DESCRIPTION metadata in one record * Install RStan model-compilation headers explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #35 was merged before the maintainer had reviewed it or explicitly authorized a merge. This PR reverts its squash commit,
4b7d92253e5f82ba764ebe244b55e098c951b09a, so the implementation can return through human review.The revert removes the development-dependency workflow, its fitted-model check, and the added
svgliteworkflow dependency. Its tree exactly matches the state immediately before #35 (95b5049b99dd944971067c46862d580390b047c6). The original implementation is preserved ondependency-canariesfor a separate review PR.The exact revert also removes the
svglitefix for the previously observed pkgdown rendering failure. That failure may therefore return until the dependency change is reviewed and restored. Required CI checks remain repository settings and are not modified by this PR.Validation: the staged tree matches the pre-merge commit exactly,
git diff --checkpasses, and actionlint passes for the reverted pkgdown workflow. No package code changes are introduced.This is a draft for human review. It must not be merged without the maintainer's explicit instruction.