Add missing GetVirtualScreenSize stub to HeadlessWrapper#1789
Open
YangLeoZhao wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Add missing GetVirtualScreenSize stub to HeadlessWrapper#1789YangLeoZhao wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
YangLeoZhao wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Launch.lua calls GetVirtualScreenSize() in DrawPopup() and during restart, but HeadlessWrapper.lua only stubs GetScreenSize() and GetScreenScale(). When running headless and an error triggers DrawPopup on the first OnFrame, this causes a crash because GetVirtualScreenSize is not yet defined (Modules/Common.lua where it is normally defined hasn't loaded yet). The stub delegates to GetScreenSize() since GetScreenScale() returns 1 (no scaling) in headless mode, matching what the real implementation in Common.lua would produce. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeadlessWrapper.luastubsGetScreenSize()andGetScreenScale(), but notGetVirtualScreenSize()Launch.luacallsGetVirtualScreenSize()inDrawPopup()(line 390) and during restart (line 125)DrawPopupon the firstOnFrame, this causes a crash becauseGetVirtualScreenSizeis not yet defined —Modules/Common.lua(where it is normally defined, line 1044) hasn't loaded yet at that pointGetScreenSize()sinceGetScreenScale()returns 1 (no scaling) in headless mode, matching what the real implementation inCommon.luawould produceReproduction
HeadlessWrapper.luaDrawPopupbeforeModules/Common.luais loaded (e.g., an initialization error on the firstOnFrame)attempt to call global 'GetVirtualScreenSize' (a nil value)Test plan
Common.lua's implementation (sinceGetScreenScale()returns 1,GetVirtualScreenSize()==GetScreenSize())