Absent Amulet grants a reservation-free skill#2353
Open
jokker23 wants to merge 1 commit into
Open
Conversation
When the Absent Amulet grants a reserving skill (Archmage), the skill is provided for free in-game and reserves no Spirit. PoB was still charging the granted skill's full base reservation (100 Spirit for Archmage), overstating reserved Spirit and understating unreserved Spirit for any build using the amulet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Absent Amulet not reserving properly.
Description of the problem being solved:
When the Absent Amulet grants a reserving skill (Archmage), the skill is provided for free in-game and reserves no Spirit. PoB was still charging the granted skill's full base reservation (100 Spirit for Archmage), overstating reserved Spirit and understating unreserved Spirit for any build using the amulet.
The reservation waiver is scoped strictly to skills granted by the Absent Amulet:
Steps taken to verify a working solution:
spec/System/TestBirthedReservation_spec.lua: amulet-granted skill reserves 0, amulet-granted skill + a support gem reserves only the support's amount.spec/Systembusted suite — all passing, no regressions.ModCache.luaand confirmed no diff.Link to a build that showcases this PR:
poe.ninja
Before screenshot:
After screenshot: