Rework TradeQueryGenerator to use exported stat names and values#2355
Draft
vaisest wants to merge 8 commits into
Draft
Rework TradeQueryGenerator to use exported stat names and values#2355vaisest wants to merge 8 commits into
vaisest wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This PR reworks the QueryMods.lua and weight generation to avoid having to parse mod texts which is not easy and results in extra work, like having to figure out when you need to negate mod values, etc.
Instead, this exports stat names and values for mods:
These can be used to easily generate a modline later with
data.describeStats(), while being able to plug the stat value directly into the trade site. This, in my opinion, makes the code a lot more readable and simpler. The existing code also works around some exceptions, like "an additional" being converted to 1 additional. Issues like these are completely avoidedThis is based on #2347
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: