Add support for Idolatry and change how Bonded lines are parsed#2366
Open
LocalIdentity wants to merge 1 commit into
Open
Add support for Idolatry and change how Bonded lines are parsed#2366LocalIdentity wants to merge 1 commit into
LocalIdentity wants to merge 1 commit into
Conversation
Export Bonded modifiers into separate rune data sub-tables instead of adding "Bonded:" as a line prefix. Fix export of some Bonded mods that had separate stat entries that were not being combined. e.g. Perfect Resolve Rune did not add the bonded mods for armour, weapons, wands and staves Rebuild rune mods from rune data, keeping Bonded lines unparsed until they are enabled. Add support for the global `CanUseBonded` flag and the item-local Idol-only unlock, including socketed augment effect scaling. Add tests for many of the new changes. This now fixes all the mods that didn't parse correctly before because they were not a piece-meal mod and required explicit "Bonded:" ModParser lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Idolatry didn't work as we didn't have any logic for item-specific bonded mod enablers
Bonded mods also relied on us parsing the
Bonded:prefix at the start of each line which caused issues for non-piecemeal mods that required their own explicit linesWe now export Bonded modifiers into separate sub-tables instead of adding "Bonded:" as a line prefix.
Fix export of some Bonded mods that had separate stat entries that were not being combined.
e.g. Perfect Resolve Rune did not add the bonded mods for armour, weapons, wands and staves
Rebuild rune mods from rune data, keeping Bonded lines unparsed until they are enabled.
Add tests for many of the new changes.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/m8abhw0x
Before screenshot:
After screenshot: