Rebirth of Auto-complete Support #962
Open
+212
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New function for registering commands that has an auto-complete handler argument. Also added a config value for disabling the new console (in case it causes problems on some terminals).
Should fix the slowdown from logging spam while still supporting colors properly.
Pathoschild
force-pushed
the
develop
branch
3 times, most recently
from
f302934 to
7a91eee
Compare
Pathoschild
force-pushed
the
develop
branch
5 times, most recently
from
27fb753 to
8bbbf08
Compare
Pathoschild
force-pushed
the
develop
branch
2 times, most recently
from
cfac33e to
6c0c089
Compare
Owner
|
We discussed this on Discord, but for the record this PR hasn't been forgotten. One goal for SMAPI 5.0.0 is a redesigned command API which could include...
Since this PR needs an API change, it'll most likely become part of the new API instead of changing the to-be-obsolete API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function for registering commands that has an auto-complete handler argument. Also added a config value for disabling the new console (in case it causes problems on some terminals).