Remove flow-api gRPC dependency from e2e tests#3899
Draft
iskakaushik wants to merge 3 commits intomainfrom
Draft
Remove flow-api gRPC dependency from e2e tests#3899iskakaushik wants to merge 3 commits intomainfrom
iskakaushik wants to merge 3 commits intomainfrom
Conversation
e2e tests now use FlowRequestHandler in-process, so the flow-api server is no longer needed.
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Handler methods like CreateCDCFlow return cmd.APIError, which typed the err variable as APIError. Subsequent := reuse with functions returning plain error (GetPeerflow, loadConfigFromCatalog, etc.) caused compile failures. Use apiErr for handler returns to keep err as plain error.
Contributor
|
Great direction @iskakaushik! As this is an infra change, please make sure to add relevant reviewers when it's ready to be taken a look at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all gRPC
FlowServiceClientcalls (connecting to flow-api on port 8112) in e2e tests with direct in-process calls to*cmd.FlowRequestHandler. This removes the need to have a running flow-api server when running e2e tests, sinceFlowRequestHandlerhas the same method signatures and itsAPIErrorreturn type satisfies theerrorinterface.