feat(bigquery): add PEERDB_BIGQUERY_GEO_MAKE_VALID#3918
Open
lukejudd-lux wants to merge 1 commit intoPeerDB-io:mainfrom
Open
feat(bigquery): add PEERDB_BIGQUERY_GEO_MAKE_VALID#3918lukejudd-lux wants to merge 1 commit intoPeerDB-io:mainfrom
lukejudd-lux wants to merge 1 commit intoPeerDB-io:mainfrom
Conversation
…r ST_GEOGFROMTEXT BigQuery uses S2 geometry which has stricter validity rules than GEOS/PostGIS. Geometries that are valid in PostGIS can fail to load into BigQuery due to S2 edge intersection checks. This adds a per-mirror configurable setting that passes make_valid => TRUE to ST_GEOGFROMTEXT during CDC merge and initial load, allowing BigQuery's S2 engine to repair geometries on ingest. Defaults to false (no behavior change for existing mirrors).
lukejudd-lux
requested a deployment
to
external-contributor
GitHub Actions
Waiting
lukejudd-lux
requested a deployment
to
external-contributor
GitHub Actions
Waiting
lukejudd-lux
requested a deployment
to
external-contributor
GitHub Actions
Waiting
lukejudd-lux
requested a deployment
to
external-contributor
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3920
feat(bigquery): add
PEERDB_BIGQUERY_GEO_MAKE_VALIDdynamic setting forST_GEOGFROMTEXTBigQuery uses S2 geometry which has stricter validity rules than GEOS/PostGIS. Geometries that are valid in PostGIS can fail to load into BigQuery due to S2 edge intersection checks.
This adds a configurable setting that passes make_valid => TRUE to
ST_GEOGFROMTEXTduring CDC merge and initial load, allowing BigQuery's S2 engine to repair geometries on ingest.Defaults to false (no behaviour change for existing mirrors).