Switchboard - a Go tool to query peers (MySQL)#3979
Open
ilidemi wants to merge 8 commits intoswitchboard-pgfrom
Open
Switchboard - a Go tool to query peers (MySQL)#3979ilidemi wants to merge 8 commits intoswitchboard-pgfrom
ilidemi wants to merge 8 commits intoswitchboard-pgfrom
Conversation
680b8d6 to
55d523c
Compare
f49d35e to
6481295
Compare
ilidemi
commented
Feb 21, 2026
Comment on lines
+5
to
+9
| branches: [main, switchboard-pg] | ||
| push: | ||
| branches: [main] | ||
| pull_request_target: | ||
| branches: [main] | ||
| branches: [main, switchboard-pg] |
Contributor
Author
There was a problem hiding this comment.
Undo before merging
Contributor
Author
There was a problem hiding this comment.
We could have a convention of stacked-* that also trigger all the checks. Not in this PR though
3587233 to
1b3f570
Compare
6fb06bc to
3ec8077
Compare
1c500b0 to
6b73b79
Compare
ilidemi
commented
Feb 21, 2026
Comment on lines
+5
to
+9
| branches: [main, switchboard-pg] | ||
| pull_request: | ||
| branches: [main] | ||
| branches: [main, switchboard-pg] | ||
| pull_request_target: | ||
| branches: [main] | ||
| branches: [main, switchboard-pg] |
Contributor
Author
There was a problem hiding this comment.
Undo before merging
Comment on lines
+5
to
+7
| branches: [ "main", "customer-*", "stable", "switchboard-pg" ] | ||
| pull_request: | ||
| branches: [ "main", "customer-*", "stable" ] | ||
| branches: [ "main", "customer-*", "stable", "switchboard-pg" ] |
Contributor
Author
There was a problem hiding this comment.
Undo before merging
ilidemi
commented
Feb 21, 2026
| on: | ||
| pull_request: | ||
| branches: [main] | ||
| branches: [main, switchboard-pg] |
Contributor
Author
There was a problem hiding this comment.
Undo before merging
6b73b79 to
c47c611
Compare
9f14fe0 to
2e1798c
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
c47c611 to
4196973
Compare
2e1798c to
7ed8a7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #3978
No surprises here, a straightforward implementation of the interface plus tests. Query guarding is done via a RO transaction + running the query through a parser and filtering statements. 60% of lines are tests.