Merged
Conversation
Without this we create-attach-detach, and it gets destroyed after the first connection, making the HTTP cache unusable. This makes sure that the area remains there even when there's no active reference to it.
Otherwise the destructor tries to do this during library unloading time, but at that time shmem_exit already completed and we spam the error log with allocator errors.
jeltz
approved these changes
Feb 10, 2026
Collaborator
jeltz
left a comment
jeltz
left a comment
There was a problem hiding this comment.
Would be nice if we somehow could have a test actually using the cache too.
Collaborator
Author
|
Yes, but that's very difficult to setup with keycloak because of their no caching policy :( I could add a GUC to override the http headers maybe? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.